[PATCH] D97914: [TargetLowering] Use HandleSDNodes to prevent nodes from being deleted by recursive calls in getNegatedExpression.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 06:10:43 PST 2021


spatel added a comment.

This keeps getting more complicated, but I don't have any better suggestions.
I am still wondering if we can/should assert within getNode() that operand values are not already deleted nodes. Ie, passing those nodes in means the caller has definitely gone out-of-bounds in some way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97914/new/

https://reviews.llvm.org/D97914



More information about the llvm-commits mailing list