[PATCH] D96394: [AVR] Improve inline assembly

[Ben Shi via Phabricator via llvm-commits]

benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1918-1921
-  // We only support i8 and i16.
-  //
-  //:FIXME: remove this assert for now since it gets sometimes executed
-  // assert((VT == MVT::i16 || VT == MVT::i8) && "Wrong operand type.");
----------------
aykevl wrote:
> Why did you remove this assert entirely? It looks like a sensible assert.
First, the assert should not be open since llvm will crash if user specified an i32 variable in inline assembly.

Second, avr-gcc does generate correct asm code for i32/i64, but llvm-avr does not. And I plan to do a further check on that.

Any way, the commented assert is unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96394/new/

https://reviews.llvm.org/D96394