[PATCH] D97933: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro created this revision.
ro added a reviewer: vitalybuka.
ro added a project: Sanitizers.
Herald added subscribers: pengfei, fedor.sergeev.
ro requested review of this revision.
Herald added a subscriber: Sanitizers.

One ASan test currently `XPASS`es on Solaris:

  AddressSanitizer-i386-sunos :: TestCases/Posix/unpoison-alternate-stack.cpp

It was originally `XFAIL`ed in D88501 <https://reviews.llvm.org/D88501> because `longjmp` from a signal handled is highly
unportable, warned against in XPG7, and was not supported by Solaris `libc` at the time.

However, since then support has been added for some cases including the current one,
so the `XFAIL` can go.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.

However, there's a way more portable alternative, namely using `siglongjmp` instead
that might also be considered.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97933

Files:
  compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp


Index: compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
===================================================================
--- compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
+++ compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
@@ -7,8 +7,6 @@
 // RUN: %run %t
 
 // XFAIL: ios && !iossim
-// longjmp from signal handler is unportable.
-// XFAIL: solaris
 
 #include <algorithm>
 #include <cassert>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97933.328122.patch
Type: text/x-patch
Size: 455 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210304/63f559a1/attachment.bin>