[PATCH] D97932: [asan][test] Don't XFAIL Posix/no_asan_gen_globals.c on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro created this revision.
ro added a reviewer: vitalybuka.
ro added a project: Sanitizers.
Herald added subscribers: pengfei, fedor.sergeev.
ro requested review of this revision.
Herald added a subscriber: Sanitizers.

One ASan test currently `XPASS`es on Solaris:

  AddressSanitizer-i386-sunos :: TestCases/Posix/no_asan_gen_globals.c

It was originally `XFAIL`ed in D88218 <https://reviews.llvm.org/D88218> because Solaris `ld`, unlike GNU `ld`, doesn't
strip local labels.  Since then, the integrated assembler has stopped emitting those
local labels, so the difference becomes moot and the `XFAIL` can go.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97932

Files:
  compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c


Index: compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
===================================================================
--- compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
+++ compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c
@@ -1,7 +1,5 @@
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
 // XFAIL: android
-// Bug 47607
-// XFAIL: solaris
 // Make sure ___asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97932.328121.patch
Type: text/x-patch
Size: 514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210304/895e7c4d/attachment.bin>