[PATCH] D97663: [llvm-objcopy] Fix crash for binary input files with non-ascii names

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 02:58:00 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:1293
   std::string SanitizedFilename = MemBuf->getBufferIdentifier().str();
   std::replace_if(std::begin(SanitizedFilename), std::end(SanitizedFilename),
+                  [](char C) { return !isAlnum(C); }, '_');
----------------
FYI - I've fixed this linter issue locally, just haven't bothered uploading a new diff to resolve it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97663/new/

https://reviews.llvm.org/D97663



More information about the llvm-commits mailing list