[PATCH] D96980: [amdgpu] Revert agnostic SGPR spill.

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 4 00:54:46 PST 2021


critson added a comment.

In D96980#2602610 <https://reviews.llvm.org/D96980#2602610>, @sebastian-ne wrote:

> I think I found a way how exec can get zero before a restore (disclaimer: I’m not sure if that is valid code in any of the graphics APIs or if something similar can happen in compute. It should be valid LLVM IR, however).
> ... code example omitted...

I agree this could happen if we use function calls in pixel shaders (PS); however, I don't think we have any plans to do this yet?
(Currently the only expected place for a kill is in PS, although we do support it elsewhere.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96980/new/

https://reviews.llvm.org/D96980



More information about the llvm-commits mailing list