[PATCH] D97903: [dfsan] Increase coverage of vector and select tests

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao added inline comments.


================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/call.ll:2
 ; RUN: opt < %s -dfsan -S | FileCheck %s
+; RUN: opt < %s -dfsan -dfsan-fast-16-labels -S | FileCheck %s
 ; RUN: opt < %s -passes=dfsan -S | FileCheck %s
----------------
fast16 and legacy modes have the same code path tested by this file: it does not check ld/st much.
It is fine to ignore -dfsan-fast-16-labels.
We may add the new 8bit mode if its codegen introduces different code path.


================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/vector.ll:11-12
 define <4 x i4> @pass_vector(<4 x i4> %v) {
-  ; ARGS_ABI: @"dfs$pass_vector"
-  ; ARGS_ABI: ret { <4 x i4>, i16 }
-  
-  ; FAST16: @"dfs$pass_vector"
-  ; FAST16: {{.*}} = load i16, i16* bitcast ([100 x i64]* @__dfsan_arg_tls to i16*), align [[ALIGN:2]]
-  ; FAST16: store i16 %1, i16* bitcast ([100 x i64]* @__dfsan_retval_tls to i16*), align [[ALIGN]]
+  ; ARGS_ABI-LABEL: @"dfs$pass_vector"
+  ; ARGS_ABI-SAME: (<4 x i4> %[[VEC:.*]], i[[#SBITS]] %[[LABEL:.*]])
+  ; ARGS_ABI-NEXT: %[[#REG:]] = insertvalue { <4 x i4>, i[[#SBITS]] } undef, <4 x i4> %[[VEC]], 0
----------------
Does ARGS_ABI-LABEL @"dfs$pass_vector"(<4 x i4> %[[VEC:.*]], i[[#SBITS]] %[[LABEL:.*]]) also work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97903/new/

https://reviews.llvm.org/D97903