[PATCH] D94741: [Utils] Check for more global information in update_test_checks

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 3 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:377
 class NamelessValue:
-    def __init__(self, check_prefix, ir_prefix, ir_regexp):
+    def __init__(self, check_prefix, check_key, ir_prefix, global_ir_prefix, global_ir_prefix_regexp, ir_regexp, global_ir_rhs_regexp, is_before_functions):
         self.check_prefix = check_prefix
----------------
jdoerfert wrote:
> mtrofin wrote:
> > nit: could you run a linter to split, insomuch as possible, long lines? I (think I) know we don't enforce a code style of .py, but I'd argue there's readability value in doing it. (no need to scroll right, less eye movement effort)
> I can, but FWIW, this isn't a complete patch yet. It does fix issues we have right now when global values, like #1 or !4, appear in a function but there was an issue with this when I run it on the Attributor tests.
> 
> And there are no tests :(
> 
> Unsure when I get the time to revisit this, anyone that thinks this is useful, pick up what you want.
If we define a linter I can run it. For now I broke a few long lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94741/new/

https://reviews.llvm.org/D94741