[PATCH] D97905: [lld-macho] Include install name in error messages for dylibs from TBDs
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 3 19:24:56 PST 2021
oontvoo added inline comments.
================
Comment at: lld/MachO/InputFiles.cpp:709
- dylibName = saver.save(interface.getInstallName());
compatibilityVersion = interface.getCompatibilityVersion().rawValue();
----------------
oontvoo wrote:
> why does this need to move?
Oh, never mind - because `toString()` needs it.
Maybe you could move the other two fields too? (just in case something else comes up)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97905/new/
https://reviews.llvm.org/D97905
More information about the llvm-commits
mailing list