[PATCH] D97127: [AVR] Improve 8/16 bit atomic operations

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 18:42:35 PST 2021


benshi001 added a comment.

In D97127#2600159 <https://reviews.llvm.org/D97127#2600159>, @aykevl wrote:

> In D97127#2593329 <https://reviews.llvm.org/D97127#2593329>, @benshi001 wrote:
>
>> Do we need a test case to show the right AVR assembly ? Or at least shows that the points `#1` and `#2` in your comment are fixed.
>
> I think that would imply using hardcoded registers in the test. Is that what you mean?

No. I meant, you have shown a case `void atomicadd(_Atomic char *val)` and corresponding assembly, and I would like to see the change of the generated assembly, and wonder if the change can be added as a test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97127/new/

https://reviews.llvm.org/D97127



More information about the llvm-commits mailing list