[PATCH] D97436: [lld-link] Add safe icf mode to lld-link, which does safe icf for all sections.

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 16:48:57 PST 2021


zequanwu added a comment.

In D97436#2601752 <https://reviews.llvm.org/D97436#2601752>, @thakis wrote:

> I'm super confused by this change. lld-link used to do aggressive icf for code and safe icf for data. The consensus on https://bugs.chromium.org/p/chromium/issues/detail?id=1087923 was that we want aggressive icf for both code and data, like lld on other platforms. But this change adds an option to make ICF less aggressive, not more aggressive, from what I understand (correct?)

The motivation for this is from: https://bugs.chromium.org/p/chromium/issues/detail?id=1169276, which is for better debugging experience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97436/new/

https://reviews.llvm.org/D97436



More information about the llvm-commits mailing list