[PATCH] D97350: [SampleFDO] Another fix to prevent repeated indirect call promotion in sample loader pass

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

In D97350#2601716 <https://reviews.llvm.org/D97350#2601716>, @hoy wrote:

> Thank for the fix. I've been seeing an assert failure related to ICP. Do you think that can be fixed by this patch?
>
> llvm/lib/Analysis/IndirectCallPromotionAnalysis.cpp:78: uint32_t llvm::ICallPromotionAnalysis::getProfitablePromotionCandidates(const llvm::Instruction*, uint32_t, uint64_t): Assertion `Count <= RemainingCount' failed.

Likely. I don't know the exact reason why the old patch triggered the assertion, but it is likely the patch will fix it because it makes the value count logic more easy to follow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97350/new/

https://reviews.llvm.org/D97350