[PATCH] D97789: [dfsan] Propagate origin tracking at store

Wed Mar 3 16:29:03 PST 2021

stephan.yichao.zhao added inline comments.

================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/origin_ldst.ll:306
+  ; CHECK: [[INTP:%.*]] = ptrtoint {{.*}} %p to i64
+  ; CHECK: [[OFFSET:%.*]] = and i64 [[INTP]], -123145302310913
+  ; CHECK: [[ORIGIN_OFFSET:%.*]] = add i64 [[OFFSET]], 35184372088832
----------------
gbalats wrote:
> Do these have to be exact? If we abstract them to `[[#ADDR]]` it will be easier to support fast8 later or other layout changes.
For most other cases I think using [[#ADDR]] should work.
We may want to keep one such a check to 'cover' this addressing pattern. 
I moved this pattern check into basic.ll with -D.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97789/new/

https://reviews.llvm.org/D97789