[PATCH] D97774: [flang] Detect circularly defined interfaces of procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added a comment.

Note that we could use the initial address in the cooked character stream as the basis for the "<" operator.  I used that in an earlier implementation, and it worked fine and was immune to changes caused by calls to ReplaceName().  But it has the potential problem that there may be cases where we're comparing symbols from .mod files.  Peter's solution of serial numbers would fix this.

Note also that I believe that currently, all sets of symbols in the compiler are declared as SymbolSet, which is an unordered set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97774/new/

https://reviews.llvm.org/D97774