[PATCH] D97350: [SampleFDO] Another fix to prevent repeated indirect call promotion in sample loader pass

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 15:05:29 PST 2021


wmi updated this revision to Diff 327938.
wmi added a comment.

Address David's comment. By using -1 to represent targets which have been promoted in the value profile, we only have to sort the values in count descending order, and choose the top MaxNumPromotions values whenever we store or load the values from value profile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97350/new/

https://reviews.llvm.org/D97350

Files:
  llvm/include/llvm/ProfileData/InstrProf.h
  llvm/lib/Analysis/IndirectCallPromotionAnalysis.cpp
  llvm/lib/ProfileData/InstrProf.cpp
  llvm/lib/Transforms/IPO/SampleProfile.cpp
  llvm/test/Transforms/SampleProfile/Inputs/norepeated-icp-2.prof
  llvm/test/Transforms/SampleProfile/indirect-call.ll
  llvm/test/Transforms/SampleProfile/norepeated-icp-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97350.327938.patch
Type: text/x-patch
Size: 23822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210303/b31d7edc/attachment.bin>


More information about the llvm-commits mailing list