[PATCH] D97873: [Attributor] Enable heap-to-stack of any size

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, two nits.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:5161
+        }
+      }
       if (auto *Size = dyn_cast<ConstantInt>(I.getOperand(0)))
----------------
Can you put these 4 lines in a helper lambda, we now replicate it a lot.


================
Comment at: llvm/test/Transforms/Attributor/lowerheap.ll:35
+
+attributes #0 = { nounwind willreturn }
----------------
can you move this in the heap2stack test case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97873/new/

https://reviews.llvm.org/D97873