[PATCH] D97881: [CodeView] Truncate Long Type Names With A Hash

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 12:28:56 PST 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp:186-187
+
+        StringRef N = NameB;
+        StringRef U = UniqueB;
+        error(IO.mapStringZ(N));
----------------
Are these locals necessary? We should be able to map NameB and UniqueB directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97881/new/

https://reviews.llvm.org/D97881



More information about the llvm-commits mailing list