[PATCH] D97833: [InstCombine] Move statepoint intrinsic handling from visitCall to visitCallBase

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 12:24:06 PST 2021


reames added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2267
+    OperandBundleDef NewBundle("gc-live", NewLiveGc);
+    if (isa<CallInst>(&Call))
+      return CallInst::CreateWithReplacedBundle(cast<CallInst>(&Call),
----------------
reames wrote:
> OT: It looks like we could sink CreateWithReplacementBundle to the CallSite base and simplify some code here.  Might be a good cleanup.  
I went ahead and did this since it was easy.  Make sure you rebase over 99f54173.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97833/new/

https://reviews.llvm.org/D97833



More information about the llvm-commits mailing list