[PATCH] D97472: [test] Use host platform specific error message substitution in lit tests

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D97472#2600955 <https://reviews.llvm.org/D97472#2600955>, @abhina.sreeskantharajan wrote:

> In D97472#2600526 <https://reviews.llvm.org/D97472#2600526>, @jdenny wrote:
>
>> I may be lost.  Why is `--ignore-case` still needed in `llvm/test/tools/yaml2obj/ELF/DWARF/debug-gnu-pubnames.yaml`?  I thought the special case for win32 was supposed to handle that.
>
> I missed this testcase in my old patch. I noticed it because it started to fail when I tried to add --ignore-case as a solution. I can fix it in this patch as well if desired or open a separate patch for it after this one.

Either way is fine by me.  I was just concerned I had misunderstood what was happening.

Based on @jhenderson's comments, it sounds like C++ code could still call `strerror(EINVAL)` on windows.  It doesn't look like that would be handled by this patch, but I suppose we can cross that bridge if we actually come to it.

Of the solutions I've seen, the current one seems best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97472/new/

https://reviews.llvm.org/D97472