[PATCH] D97866: [lld-macho] Fix & fold reexport-nested-libs test into stub-link.s

Wed Mar 3 11:54:32 PST 2021

int3 added inline comments.

================
Comment at: lld/test/MachO/Inputs/libReexportSystem.tbd:8
   - archs:      [ i386, x86_64 ]
-    re-exports: [ '/usr/lib/libSystem' ]
-    symbols:    [ __crashreporter_info__, _cache_create ]
-
+    re-exports: [ '/usr/lib/libSystem.dylib' ]
+...
----------------
oontvoo wrote:
> It wasn't able to find the libSystem with `.dylib` (because it was trying to looking for a `.tbd` extension.
> I'm curious how your change fixed it 
hmm I'm not sure why it didn't work for you. But if `resolveDylibPath` doesn't find a file ending in `.dylib`, it will replace `.dylib` with `.tbd` and try to find that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97866/new/

https://reviews.llvm.org/D97866