[PATCH] D97649: [InstrProfiling] Place __llvm_prf_vnodes and __llvm_prf_names in llvm.used on ELF

Wed Mar 3 11:03:22 PST 2021

MaskRay added a comment.

In D97649#2600694 <https://reviews.llvm.org/D97649#2600694>, @MaskRay wrote:

> In D97649#2600311 <https://reviews.llvm.org/D97649#2600311>, @thakis wrote:
>
>> This breaks instrprof-value-merge.c on our bots (linux only): https://ci.chromium.org/ui/p/chromium/builders/try/linux_upload_clang/1394/overview
>>
>> It fails in stage 0, which is a pretty vanilla build.
>>
>> I reverted this for now in 64f5d7e9725b1e1b9d70628e741aa4390795d510 <https://reviews.llvm.org/rG64f5d7e9725b1e1b9d70628e741aa4390795d510>
>>
>> Please let me know if you need help reproducing :)
>
> How can I reproduce it?
>
> This works in normal builds.

@thakis said this is a Ubuntu 14.04 bot. I guess it may have an old binutils where `--gc-sections` might never work properly.
(It reminds me of https://reviews.llvm.org/D97110#2583184 a binutils ~2.28 bug)

I'll omit `--gc-sections` in `instrprof-value-merge.c` for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97649/new/

https://reviews.llvm.org/D97649