[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Are we missing a test that goes all the way from __attribute__((used)) -> IR -> LTO? It seems such a test would have helped catch the issue caused by the change of that attribute.



================
Comment at: llvm/test/ThinLTO/X86/asm.ll:6
+
+; RUN: llvm-lto2 run %t/a.bc %t/b.bc -o %t/out -save-temps -r=%t/a.bc,ref,plx -r=%t/b.bc,ff_h264_cabac_tables,pl
+
----------------
Should we be checking the output somewhere? I'm assuming there is a missing FileCheck that corresponds to the CHECK further below.


================
Comment at: llvm/test/ThinLTO/X86/asm.ll:11
+; NM-NOT: {{.}}
+; NM:     ---------------- T ref
+; NM-NOT: {{.}}
----------------
What is the behavior here without this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97755/new/

https://reviews.llvm.org/D97755