[PATCH] D97588: [AIX] Disable $ORIGIN rpath

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 09:31:56 PST 2021


DiggerLin added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:2112
+    set_property(TARGET ${name} PROPERTY BUILD_WITH_INSTALL_RPATH ON)
+    return()
   elseif(UNIX)
----------------
in the following 
  # Enable BUILD_WITH_INSTALL_RPATH unless CMAKE_BUILD_RPATH is set.
  if("${CMAKE_BUILD_RPATH}" STREQUAL "")
    set_property(TARGET ${name} PROPERTY BUILD_WITH_INSTALL_RPATH ON)
  endif()

we enable the PROPERTY BUILD_WITH_INSTALL_RPATH anyway?

https://reviews.llvm.org/D93177  [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97588/new/

https://reviews.llvm.org/D97588



More information about the llvm-commits mailing list