[PATCH] D97748: [SystemZ][z/OS] Add support to validate a HLASM Label.

[Anirudh Prasad via Phabricator via llvm-commits]

anirudhp marked 14 inline comments as done.
anirudhp added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp:1614
+    SMLoc Loc = Token.getLoc();
+
+    // An HLASM label cannot exceed greater than 63 characters.
----------------
hubert.reinterpretcast wrote:
> It might not hurt to check that the string isn't empty somehow.
I would assume the parsing support which will eventually make use of this routine, will ensure that we don't call it if its empty. But like you mentioned, there's no harm in checking if it isn't empty. I've added the check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97748/new/

https://reviews.llvm.org/D97748