[PATCH] D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451)

Wed Mar 3 08:58:39 PST 2021

tambre added inline comments.

================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:242
+    set(compiler_args -DCMAKE_ASM_COMPILER=${CMAKE_ASM_COMPILER}
+                      -DCMAKE_ASM_COMPILER_TARGET=${ARG_TARGET_TRIPLE}
+                      -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
----------------
zero9178 wrote:
> I think this could potentially cause issues since callers might not specify TARGET_TRIPLE. Would it maybe make sense to move the block from line 214 further down to also affect the cross compiling build? 
Not specifying `TARGET_TRIPLE` probably means non-working crosscompiling for the caller. Only such caller seems to be for the LLVM test suite, which I imagine isn't supported for crosscompiling.

But moving the block down is simpler. Done, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97855/new/

https://reviews.llvm.org/D97855