[PATCH] D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax

Anirudh Prasad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 08:23:35 PST 2021


anirudhp added a comment.

In D97703#2600429 <https://reviews.llvm.org/D97703#2600429>, @scott.linder wrote:

> Can you add a test? It seems like you already have the `jo *-4` example so just a test that the following does what you expect would be enough for me:
>
>   * comment
>   jo *-4

Thank you for your feedback! I will address the other inline comments shortly. However, for the test, as mentioned in the description, we don't have MCStreamer support yet for the z/OS target, so any test would just fail outright (as mentioned above, we are working on putting it up, but I can't provide a fixed timeframe). I understand that this is problematic, since its best practice to put up a test along with any changes to implementation. Do you have any other recommendations as to how to go about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97703/new/

https://reviews.llvm.org/D97703



More information about the llvm-commits mailing list