[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Still a lot of instances of `bool isFoo` variables/arguments that should be `bool IsFoo`.



================
Comment at: llvm/lib/Target/M68k/M68kFrameLowering.cpp:350
+      // load the offset into a register and do one sub/add
+      unsigned Reg = 0;
+
----------------
jrtc27 wrote:
> `Register`?
I meant the type, not changing the name. Should avoid the need to cast.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:2758-2763
+  //  thisMBB:
+  //  ...
+  //   TrueVal = ...
+  //   cmpTY ccX, r1, r2
+  //   bCC copy1MBB
+  //   fallthrough --> copy0MBB
----------------
This comment didn't get updated for the capitalised names


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:2866
+  //         retq
+  //
+  MachineInstr *CascadedCMOV = nullptr;
----------------
Does any of this entire comment block apply to m68k? The assembly is X86 SSE...


================
Comment at: llvm/lib/Target/M68k/M68kInstrInfo.h:34
+// Forward declaration
+const uint8_t *getMCInstrBeads(unsigned);
+
----------------
Include the argument name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391