[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Hopefully the last set of comments for this patch



================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:349
+
+def NAME#"8dd"  : MxBiArOp_RFRR_EAd<MN, NODE, MxType8d,  CMD>;
+def NAME#"16dd" : MxBiArOp_RFRR_EAd<MN, NODE, MxType16d, CMD>;
----------------
Hm this one got missed too and I managed to not spot it last time.


================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:371
+    : MxInst<(outs), (ins TYPE.ROp:$lhs, TYPE.ROp:$rhs),
+      "cmp."#TYPE.Prefix#"\t$lhs, $rhs",
+     [(set CCR, (MxCmp TYPE.VT:$lhs, TYPE.VT:$rhs))],
----------------
Indentation is still off for some of these. Please go through all your MxInst's (and instances of subclasses thereof, e.g. uses of MxBcc that I've also noticed are still wrong) and check them.


================
Comment at: llvm/lib/Target/M68k/M68kInstrInfo.td:352
+let OperandType = "OPERAND_PCREL",
+    /* ParserMatchClass = M68kAbsMemAsmOperand, */
+    PrintMethod = "printPCRelImm" in {
----------------
Hm?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389