[PATCH] D94708: [IR] Introduce llvm.experimental.vector.splice intrinsic

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 3 04:13:24 PST 2021


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

The patch looks fine to me, cheers @c-rhodes.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:8643
+  if (Imm >= 0) {
+    // Load back the required element. This takes care of clamping the index if
+    // it's out-of-bounds.
----------------
nit: s/This/getVectorElementPointer/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94708/new/

https://reviews.llvm.org/D94708



More information about the llvm-commits mailing list