[PATCH] D82546: [Debugify][OriginalDIMode] Export the report into JSON file

Wed Mar 3 03:02:06 PST 2021

djtodoro added a comment.

@StephenTozer Thanks!

In D82546#2596942 <https://reviews.llvm.org/D82546#2596942>, @StephenTozer wrote:

> and also I think there should be a couple of tests for the `llvm-original-di-preservation` script - nothing too complicated, just verifying that it produces the correct HTML for a given input, as with the `opt-viewer` tests.

I'll check this.

================
Comment at: llvm/utils/llvm-original-di-preservation.py:32
+
+  html_header = "<html>\n"
+  html_header += "<head>\n"
----------------
StephenTozer wrote:
> For each of these blocks, instead of using repeated `html_header +=` you could instead use triple quotes and just write out the full HTML verbatim (using formatting to insert variables as needed), as in the other HTML generating python scripts.
It makes sense.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82546/new/

https://reviews.llvm.org/D82546