[PATCH] D97767: [AMDGPU][GlobalISel] Add support for global atomicrmw fadd

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1299
+  if (ST.hasAtomicFaddInsts())
+    Atomic.legalFor({{S32, GlobalPtr}});
 
----------------
arsenm wrote:
> Isn't this also conditional on the denorm mode or the unsafe atomic attribute? That would need to be custom and verify those are consistent
Those checks are done in SITargetLowering::shouldExpandAtomicRMWInIR for both selectiondag and globalisel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97767/new/

https://reviews.llvm.org/D97767