[PATCH] D93530: [DSE] Add support for not aligned begin/end
Evgeniy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 3 01:03:29 PST 2021
ebrevnov added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1132
+ << *EarlierWrite << "\n KILLER ( offset " << ToRemoveStart
+ << ", " << ToRemoveSize << ")\n");
----------------
fhahn wrote:
> perhaps it would be worth adjusting the message to make it clear that the second number is the size we shorten by?
I agree. This message confused me when I met it in the dump. Other places uses (start,end] notation to represent removed interval. I think it makes sense to unify this one with other places.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93530/new/
https://reviews.llvm.org/D93530
More information about the llvm-commits
mailing list