[PATCH] D96980: [amdgpu] Revert agnostic SGPR spill.

Wed Mar 3 00:58:02 PST 2021

sebastian-ne added a comment.

As far as I can see, the current state of this is

1. Carl found a bug when WQM is entered between save and restore
2. Matt and Stas have concerns about the correctness and want more verification

David claimed that we can handle the first issue (WQM) downstream (although I don’t know how he intends to do this, just hoping this never happens in practice?).
The second issue (more verification) seems to be stuck over the last weeks.

As a faster solution, can we submit D96336 <https://reviews.llvm.org/D96336> to fix the correctness issue until the remaining issues here are solved?
I can revert D96336 <https://reviews.llvm.org/D96336> once this patch is ready to go in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96980/new/

https://reviews.llvm.org/D96980