[PATCH] D97758: [CostModel][SVE] Add cost model for shuffle reverse with i1 and scalable vector

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Other than my comment on removing the fixed-width tests, the patch looks good to me.



================
Comment at: llvm/test/Analysis/CostModel/AArch64/getIntrinsicInstrCost-vector-reverse.ll:53
+  call <4 x i1> @llvm.experimental.vector.reverse.v4i1(<4 x i1> undef)
+  call <2 x i1> @llvm.experimental.vector.reverse.v2i1(<2 x i1> undef)
   ret void
----------------
I now see your code-changes only relate to scalable vectors, so these fixed-width tests are not really covering any changes in your patch. I'd suggest just removing them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97758/new/

https://reviews.llvm.org/D97758