[PATCH] D97504: [llvm-exegesis] Disable the LBR check on AMD

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:502
+VendorSignatures getVendorSignature() {
+  unsigned __attribute__((unused)) EAX = 0, EBX = 0, ECX = 0, EDX = 0;
+  unsigned MaxLeaf, Vendor;
----------------
Smells a bit weird that you're declaring EAX and EBX if you never intend to use it.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:723
 
-  Error checkFeatureSupport() const override {
+  Error checkFeatureSupport(const LLVMState &state) const override {
     // LBR is the only feature we conditionally support now.
----------------
Unless I'm missing something, `state` is no longer necessary here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97504/new/

https://reviews.llvm.org/D97504