[PATCH] D97776: [CSSPGO][llvm-profgen] Continue disassembling after illegal instruction is seen.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:270
+    } else {
+      WithColor::warning() << "Bad disassembling at "
+                           << format("%8\n" PRIx64, Offset);
----------------
wenlei wrote:
> It would be good to have one warning for a consecutive range of invalid instructions, instead of one warning for each byte. Otherwise it can be noisy.
> 
> nit: Bad disassembling -> Invalid instructions at <start> - <end>
Good point, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97776/new/

https://reviews.llvm.org/D97776