[PATCH] D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 18:10:09 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/branch-symbols.s:1
+@ RUN: llvm-mc < %s --triple=armv8a   -mattr=+mve,+lob -filetype=obj | llvm-objdump -dr - --triple armv8a --mattr=+mve,+lob | FileCheck %s
+@ RUN: llvm-mc < %s --triple=thumbv8a -mattr=+mve,+lob -filetype=obj | llvm-objdump -dr - --triple armv8a --mattr=+mve,+lob | FileCheck %s
----------------
Tip: `--no-show-raw-insn` to omit hex bytes. They are separately tested by test/MC/ARM encoding tests, so no need to duplicate in llvm-objdump tests.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/branch-symbols.s:10
+  ble foo
+@ CHECK:       0: fe ff ff ea   b       #-8 <foo>
+@ CHECK:       4: fd ff ff da   ble     #-12 <foo>
----------------
Another pain is that arm prints relative offsets, instead of absolute addresses.
Is anyone going to claim the work?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97766/new/

https://reviews.llvm.org/D97766



More information about the llvm-commits mailing list