[PATCH] D97774: [flang] Detect circularly defined interfaces of procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added a comment.

In D97774#2598594 <https://reviews.llvm.org/D97774#2598594>, @PeteSteinfeld wrote:

> In D97774#2598541 <https://reviews.llvm.org/D97774#2598541>, @kiranchandramohan wrote:
>
>> I see a failure in the buildbot.
>> https://lab.llvm.org/buildbot/#/builders/33/builds/2845
>>
>> /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/lib/Semantics/resolve-names.cpp:3655:25: error: loop variable 'procInCycle' of type 'const Fortran::common::Reference<const Fortran::semantics::Symbol>' creates a copy from type 'const Fortran::common::Reference<const Fortran::semantics::Symbol>' [-Werror,-Wrange-loop-construct]
>>
>>   for (const auto procInCycle : procsInCycle) {
>>                   ^
>>
>> /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/lib/Semantics/resolve-names.cpp:3655:14: note: use reference type 'const Fortran::common::Reference<const Fortran::semantics::Symbol> &' to prevent copying
>>
>>   for (const auto procInCycle : procsInCycle) {
>>        ^~~~~~~~~~~~~~~~~~~~~~~~
>>                   &
>
> Thanks, @kiranchandramohan.  I'll fix this.

I just pushed a change that should fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97774/new/

https://reviews.llvm.org/D97774