[PATCH] D96928: [LICM][Coroutine] Don't sink stores from loops with coro.suspend instructions
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 2 13:54:21 PST 2021
lxfind added a comment.
In D96928#2589101 <https://reviews.llvm.org/D96928#2589101>, @lxfind wrote:
>> Yes, lots of the cases follow this rules. However, as long as the values stored are loop invariant, then LICM should move store out of the loop to reduce memory operation.
>
> You are right that in some cases LICM does reduce memory operations for coroutines.
> Now that we have all agreed on the documentation part, let me think a bit more about this patch vs D87817 <https://reviews.llvm.org/D87817>
I concluded that there is no better way than disabling LICM for coroutines right now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96928/new/
https://reviews.llvm.org/D96928
More information about the llvm-commits
mailing list