[PATCH] D97628: GlobalISel: Merge and cleanup more AMDGPU call lowering code

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 13:33:18 PST 2021


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:268
+    // %concat:_<6 x s16>) = G_CONCAT_VECTORS %reg_value0, %reg_value1, %undef
+    // %dst_reg:_(<3 x s16>), %dead0, %dead1 = G_UNMERGE_VALUES %concat
+    const int NumWide = LCMTy.getSizeInBits() / PartLLT.getSizeInBits();
----------------
dead1 shouldn't be here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97628/new/

https://reviews.llvm.org/D97628



More information about the llvm-commits mailing list