[llvm] bbdb4c8 - [llvm-jitlink] Prevent missing symbols from JITLoaderGDB with MSVC mangling

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 12:46:17 PST 2021


Author: Stefan Gränitz
Date: 2021-03-02T21:44:54+01:00
New Revision: bbdb4c8c9bcef0e8db751630accc04ad874f54e7

URL: https://github.com/llvm/llvm-project/commit/bbdb4c8c9bcef0e8db751630accc04ad874f54e7
DIFF: https://github.com/llvm/llvm-project/commit/bbdb4c8c9bcef0e8db751630accc04ad874f54e7.diff

LOG: [llvm-jitlink] Prevent missing symbols from JITLoaderGDB with MSVC mangling

The issue came up on builder clang-x64-windows-msvc after 5182a7901a5d83dfd15021d01e8a1899910130ec

Added: 
    

Modified: 
    llvm/tools/llvm-jitlink/llvm-jitlink.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
index fd5331ab97af..0a2ff8088dbe 100644
--- a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
+++ b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
@@ -852,8 +852,9 @@ Session::Session(std::unique_ptr<TargetProcessControl> TPC, Error &Err)
     ObjLayer.addPlugin(std::make_unique<EHFrameRegistrationPlugin>(
         ES, ExitOnErr(TPCEHFrameRegistrar::Create(*this->TPC))));
 
-  ObjLayer.addPlugin(std::make_unique<DebugObjectManagerPlugin>(
-      ES, ExitOnErr(createJITLoaderGDBRegistrar(*this->TPC))));
+  if (!this->TPC->getTargetTriple().isOSWindows())
+    ObjLayer.addPlugin(std::make_unique<DebugObjectManagerPlugin>(
+        ES, ExitOnErr(createJITLoaderGDBRegistrar(*this->TPC))));
 
   ObjLayer.addPlugin(std::make_unique<JITLinkSessionPlugin>(*this));
 


        


More information about the llvm-commits mailing list