[PATCH] D97776: [CSSPGO][llvm-profgen] Continue disassembling after illegal instruction is seen.
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 2 12:20:55 PST 2021
wlei accepted this revision.
wlei added a comment.
This revision is now accepted and ready to land.
Thanks for working on this! LGTM
================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:228
+ Offset + PreferredBaseAddress, nulls());
+ if (Size == 0)
+ Size = 1;
----------------
Nit: how about also use Disassembled as the condition and merge this to the Line274, like:
```
if (Disassembled)
Offset += Size;
else
Offset += 1;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97776/new/
https://reviews.llvm.org/D97776
More information about the llvm-commits
mailing list