[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

[Albion Fung via Phabricator via llvm-commits]

Conanap marked 2 inline comments as done.
Conanap added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8593
+  return !convertToNonDenormSingle(ArgAPFloat);
+}
+
----------------
stefanp wrote:
> I'm wondering if it would not be better to just inline this. It's just "not" of another call. That would simplify the patch a little.
so in the process of removing this, I thought I might as well just write a non-destructive test in its place. The tests didn't have any problems with just `checkConvertToNonDenormSingle` but might as well be on the safer side of things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95458/new/

https://reviews.llvm.org/D95458