[PATCH] D97339: [lli] Add --jit-linker command line argument

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 11:58:07 PST 2021


thakis added a comment.

> I think I figured out the linux bit. `SelfTargetProcessControl::lookupSymbols` strips GlobalManglingPrefix and the test actually looks up llvm_orc_registerJITLoaderGDBWrapper without underscore. For dlsym() to find this in dlopen(NULL, ...), llvm-jitlink needs to be linked with -rdynamic. I hope it's similarly straightforward on Windows...

And I found a Windows box too. Looks like the test fails on Windows with a normal build config too. Windows doesn't support dlsym()ing (well, GetProcAddress()ing) symbols from the main executable, only from dynamic libraries. So the whole approach seems Windows-incompatible. I'll try to revert some of the bits here to unbreak stuff.

(It'd be nice to land changes spread out over time, so that if a change breaks something it's easier to revert....)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97339/new/

https://reviews.llvm.org/D97339



More information about the llvm-commits mailing list