[PATCH] D97570: [dfsan] Propagate origin tracking at load

[George Balatsouras via Phabricator via llvm-commits]

gbalats added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:2161
 
-  Align Alignment = ClPreserveAlignment ? LI.getAlign() : Align(1);
+  Value *PrimitiveShadow = nullptr, *Origin = nullptr;
   Instruction *Pos = LI.isAtomic() ? LI.getNextNode() : &LI;
----------------
Initialization seems redundant given the std::tie below.


================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/origin_ldst.ll:21
+  ; CHECK: [[O_ALLOCA:%.*]] = alloca i32, align 4
+  ; CHECK: [[SHADOW:%.*]] = load i16, i16* [[S_ALLOCA]], align 2
+  ; CHECK: [[ORIGIN:%.*]] = load i32, i32* [[O_ALLOCA]], align 4
----------------
Can these i16 expressions be generalized as in https://reviews.llvm.org/D97723 so that it requires fewer changes when we also have fast8 support?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97570/new/

https://reviews.llvm.org/D97570