[PATCH] D97776: [CSSPGO][llvm-profgen] Continue disassembling after illegal instruction is seen.

Tue Mar 2 10:02:10 PST 2021

wenlei added inline comments.

================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:241
+      else
+        outs() << "\t<unknown>";
       if (ShowSourceLocations) {
----------------
hoy wrote:
> wenlei wrote:
> > Does llvm-objdump also prints one `<unknown>` for each byte of illegal instruction, or one `<unknown>` for entire range of illegal instructions?  
> llvm-objdump prints `<unknown>` for each bad instruction: https://github.com/llvm/llvm-project/blob/eecbb1c77655d38c06e47cf32e2dcc72da45c517/llvm/tools/llvm-objdump/llvm-objdump.cpp#L1158
> 
> objdump prints `<bad`> instead.
what's the length of a bad instruction? one byte? not a big deal, but thought nice to be consistent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97776/new/

https://reviews.llvm.org/D97776