[PATCH] D97776: [CSSPGO][llvm-profgen] Continue disassembling after illegal instruction is seen.

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

I'm wondering if we need a warning when running into such cases. It's possible with data in code for assembly code, but for normal c++ compilation, this could be a red flag that something might be off?

The consequence of such cases for llvm-objdump is less important and also visible in the output, so we don't need warning there. But llvm-profgen could be different - clues like warning may help us detect subtle profile issues.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:241
+      else
+        outs() << "\t<unknown>";
       if (ShowSourceLocations) {
----------------
Does llvm-objdump also prints one `<unknown>` for each byte of illegal instruction, or one `<unknown>` for entire range of illegal instructions?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97776/new/

https://reviews.llvm.org/D97776