[PATCH] D94202: Preserve the lexical order of global variables during llvm-link merge

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 09:06:30 PST 2021


jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

This looks brittle and wrong to fiddle with the initializers of the variables and doing some complex logic.
You want to preserve the order, ok, couldn't we just sort the globals in the resulting module according to the order in the source(s)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94202/new/

https://reviews.llvm.org/D94202



More information about the llvm-commits mailing list