[PATCH] D97774: [flang] Detect circularly defined interfaces of procedures

Tue Mar 2 08:47:49 PST 2021

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

Thank you for fixing this so quickly @PeteSteinfeld !

The patch was originally reviewed and accepted in https://reviews.llvm.org/D97201. This an updated version to make sure that this change works fine regardless of the underlying platform.

This change was previously reverted because //resolve102.f90// was failing in our public Flang builders (the AAtch64 and PowerPC ones). I tested this updated patch on an AArch64 machine and can confirm that //resolve102.f90// is no longer failing. The non-determinism in the output that was causing the failure has been removed by updating `GetSeenProcs` (see https://reviews.llvm.org/D97749 for context).

LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97774/new/

https://reviews.llvm.org/D97774