[PATCH] D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D96653#2597491 <https://reviews.llvm.org/D96653#2597491>, @probinson wrote:

>> As far as I know, it does. However, before CHECK-LABEL, a CHECK-NOT range is not the same as a CHECK range:
>
> So if you have
>
>   CHECK-NOT: bar
>   CHECK-LABEL: bar
>
> it will invariably fail?  (Trying to distinguish behavior of the directives from behavior of the dump output.)

For the example input I gave, it does not fail.  I have no reason to believe the input dump is misrepresenting anything.  It's the FileCheck matching behavior that's strange: CHECK-NOT's search range before CHECK-LABEL does **not** overlap with the CHECK-LABEL match.  CHECK's search range before CHECK-LABEL **does** overlap with the CHECK-LABEL match.  At least in the experiments I've tried.  I've not investigated the implementation to determine why.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96653/new/

https://reviews.llvm.org/D96653